Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Expose Lineage, Version File Paths, and Root Collection ID in SysDb Collection Metadata

This PR extends SysDb's collection representation, plumbing metadata fields version_file_path, lineage_file_path, and root_collection_id through the API, protobuf types, database models, and associated tests for both Rust and Go. The changes are mainly required for garbage collector testing and better handling of collection versioning and ancestry.

Key Changes:
• Protobuf definition in chroma.proto updated: Collection now includes optional version_file_path, root_collection_id, and lineage_file_path.
• Go and Rust collection models, database models, and mock interfaces updated to store and propagate new fields (now using pointer semantics for nullability).
• Collection conversion/mapping logic across system layers (Go/Rust/DB) was adapted to correctly marshal/unmarshal these new fields.
• Significant tests in both Go and Rust updated or extended to validate new metadata fields are handled correctly, especially around collection creation, GC, and forks.

Affected Areas:
• Protobuf API (chroma.proto)
• SysDb internals and interfaces (Rust and Go)
• Collection model/database schema and read/write paths
• Testing infrastructure for collection metadata and GC

This summary was automatically generated by @propel-code-bot

• [ENH]: add batch get version file paths method to Sysdb #4432 : 2 dependent PRs (#4447 , #4463 )
• [ENH]: SysDb should return lineage, version file paths and root collection ID on collections #4557 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

• May 20, 6:42 PM UTC: @codetheweb merged this pull request with Graphite.